Support no_std
#332
Support no_std
#332
Conversation
Signed-off-by: koushiro <[email protected]>
Signed-off-by: koushiro <[email protected]>
Pull Request Test Coverage Report for Build 1149867009Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
@Dandandan PTAL |
There was a problem hiding this comment.
Thank you @koushiro !
I reviewed the code and the output of the new CI check https://github.com/sqlparser-rs/sqlparser-rs/pull/332/checks?check_run_id=3379689095 and it looks good to me
cc @Dandandan let me know if you have any issues with merging this PR
| @@ -13,12 +13,15 @@ include = [ | |||
| "Cargo.toml", | |||
| ] | |||
| edition = "2018" | |||
| resolver = "2" | |||
There was a problem hiding this comment.
Is the change to resolver v2 needed for this change, or is it a nice to have / drive by cleanup?
reference https://doc.rust-lang.org/cargo/reference/resolver.html#feature-resolver-version-2
There was a problem hiding this comment.
Actually, it was added to pass CI 'compile-no-std' check
Because the dev-dependency 'simple_logger' introduces the std feature of log, if resolver=2 is not used, libstd will be implicitly introduced in the CI 'compile-no-std'
stdfeature anddefaultfeatureno_stdno_stdcheckClose #286
Close #327
Signed-off-by: koushiro [email protected]